X-Git-Url: https://git.rrq.au/?a=blobdiff_plain;f=fuse_xattrs.c;h=276d57a09e9f7a18d47738791fef6c31f15cde79;hb=c2f79e5b4bfb572a0c283958f895635646203e68;hp=84007f7fe7990482c012a89f11d9172d19f6ab2c;hpb=5c2c6d3286e691f8a5b61bc2d83b9cc07bb18e9d;p=rrq%2Ffuse_xattrs.git diff --git a/fuse_xattrs.c b/fuse_xattrs.c index 84007f7..276d57a 100644 --- a/fuse_xattrs.c +++ b/fuse_xattrs.c @@ -1,7 +1,7 @@ /* fuse_xattrs - Add xattrs support using sidecar files - Copyright (C) 2016 Felipe Barriga Richards + Copyright (C) 2016-2017 Felipe Barriga Richards Based on passthrough.c (libfuse example) @@ -21,19 +21,25 @@ #include #include #include +#include #include #include +#include "fuse_xattrs_config.h" + +#include "xattrs_config.h" #include "utils.h" #include "passthrough.h" -#include "fuse_xattrs_config.h" #include "binary_storage.h" -#include "const.h" static int xmp_setxattr(const char *path, const char *name, const char *value, size_t size, int flags) { + if (xattrs_config.show_sidecar == 0 && filename_is_sidecar(path) == 1) { + return -ENOENT; + } + if (get_namespace(name) != USER) { debug_print("Only user namespace is supported. name=%s\n", name); return -ENOTSUP; @@ -47,7 +53,7 @@ static int xmp_setxattr(const char *path, const char *name, const char *value, s return -ENOSPC; } - char *_path = prepend_source_directory(xattrs_config.source_dir, path); + char *_path = prepend_source_directory(path); #ifdef DEBUG char *sanitized_value = sanitize_value(value, size); @@ -65,6 +71,10 @@ static int xmp_setxattr(const char *path, const char *name, const char *value, s static int xmp_getxattr(const char *path, const char *name, char *value, size_t size) { + if (xattrs_config.show_sidecar == 0 && filename_is_sidecar(path) == 1) { + return -ENOENT; + } + if (get_namespace(name) != USER) { debug_print("Only user namespace is supported. name=%s\n", name); return -ENOTSUP; @@ -74,7 +84,7 @@ static int xmp_getxattr(const char *path, const char *name, char *value, size_t return -ERANGE; } - char *_path = prepend_source_directory(xattrs_config.source_dir, path); + char *_path = prepend_source_directory(path); debug_print("path=%s name=%s size=%zu\n", _path, name, size); int rtval = binary_storage_read_key(_path, name, value, size); free(_path); @@ -84,12 +94,16 @@ static int xmp_getxattr(const char *path, const char *name, char *value, size_t static int xmp_listxattr(const char *path, char *list, size_t size) { + if (xattrs_config.show_sidecar == 0 && filename_is_sidecar(path) == 1) { + return -ENOENT; + } + if (size > XATTR_LIST_MAX) { debug_print("The size of the list of attribute names for this file exceeds the system-imposed limit.\n"); return -E2BIG; } - char *_path = prepend_source_directory(xattrs_config.source_dir, path); + char *_path = prepend_source_directory(path); debug_print("path=%s size=%zu\n", _path, size); int rtval = binary_storage_list_keys(_path, list, size); free(_path); @@ -99,6 +113,10 @@ static int xmp_listxattr(const char *path, char *list, size_t size) static int xmp_removexattr(const char *path, const char *name) { + if (xattrs_config.show_sidecar == 0 && filename_is_sidecar(path) == 1) { + return -ENOENT; + } + if (get_namespace(name) != USER) { debug_print("Only user namespace is supported. name=%s\n", name); return -ENOTSUP; @@ -108,7 +126,7 @@ static int xmp_removexattr(const char *path, const char *name) return -ERANGE; } - char *_path = prepend_source_directory(xattrs_config.source_dir, path); + char *_path = prepend_source_directory(path); debug_print("path=%s name=%s\n", _path, name); int rtval = binary_storage_remove_key(_path, name); free(_path); @@ -149,36 +167,6 @@ static struct fuse_operations xmp_oper = { .removexattr = xmp_removexattr, }; - -enum { - KEY_HELP, - KEY_VERSION, -}; - - -static struct fuse_opt xattrs_opts[] = { - FUSE_OPT_KEY("-V", KEY_VERSION), - FUSE_OPT_KEY("--version", KEY_VERSION), - FUSE_OPT_KEY("-h", KEY_HELP), - FUSE_OPT_KEY("--help", KEY_HELP), - FUSE_OPT_END -}; - -int is_directory(const char *path) { - struct stat statbuf; - if (stat(path, &statbuf) != 0) { - fprintf(stderr, "cannot get source directory status: %s\n", path); - return -1; - } - - if (!S_ISDIR(statbuf.st_mode)) { - fprintf(stderr, "source directory must be a directory: %s\n", path); - return -1; - } - - return 1; -} - /** * Check if the path is valid. If it's a relative path, * prepend the working path. @@ -221,6 +209,23 @@ const char *sanitized_source_directory(const char *path) { return absolute_path; } +enum { + KEY_HELP, + KEY_VERSION, +}; + +#define FUSE_XATTRS_OPT(t, p, v) { t, offsetof(struct xattrs_config, p), v } + +static struct fuse_opt xattrs_opts[] = { + FUSE_XATTRS_OPT("show_sidecar", show_sidecar, 1), + + FUSE_OPT_KEY("-V", KEY_VERSION), + FUSE_OPT_KEY("--version", KEY_VERSION), + FUSE_OPT_KEY("-h", KEY_HELP), + FUSE_OPT_KEY("--help", KEY_HELP), + FUSE_OPT_END +}; + static int xattrs_opt_proc(void *data, const char *arg, int key, struct fuse_args *outargs) { (void) data; @@ -228,6 +233,7 @@ static int xattrs_opt_proc(void *data, const char *arg, int key, case FUSE_OPT_KEY_NONOPT: if (!xattrs_config.source_dir) { xattrs_config.source_dir = sanitized_source_directory(arg); + xattrs_config.source_dir_size = strlen(xattrs_config.source_dir); return 0; } break; @@ -242,6 +248,7 @@ static int xattrs_opt_proc(void *data, const char *arg, int key, " -V --version print version\n" "\n" "FUSE XATTRS options:\n" + " -o show_sidecar don't hide sidecar files\n" "\n", outargs->argv[0]); fuse_opt_add_arg(outargs, "-ho"); @@ -249,6 +256,7 @@ static int xattrs_opt_proc(void *data, const char *arg, int key, exit(1); case KEY_VERSION: + printf("FUSE_XATTRS version %d.%d\n", FUSE_XATTRS_VERSION_MAJOR, FUSE_XATTRS_VERSION_MINOR); fuse_opt_add_arg(outargs, "--version"); fuse_main(outargs->argc, outargs->argv, &xmp_oper, NULL); exit(0);